Add check to prevent the Parsec service from running as root #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joechrisellis
force-pushed
the
not_root_check
branch
from
6ba9c2f
to
5b9efa1
Compare
ionut-arm
reviewed
Aug 13, 2020
joechrisellis
force-pushed
the
not_root_check
branch
5 times, most recently
from
0c854f6
to
4e9eaa4
Compare
ionut-arm
reviewed
Aug 13, 2020
This commit introduces a guard at the top of `main` to ensure that Parsec is not being run as root. Disallowing the Parsec service from running as root reduces attack surface in line with the principle of least privilege. This behaviour can be overridden by setting the `PARSEC_ALLOW_ROOT` environment variable. Signed-off-by: Joe Ellis <joe.ellis@arm.com>
joechrisellis
force-pushed
the
not_root_check
branch
from
4e9eaa4
to
b65cdd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a guard at the top of
mainto ensure thatParsec is not being run as root. Disallowing the Parsec service from
running as root reduces attack surface in line with the principle of
least privilege.
This behaviour can be overridden by setting the
PARSEC_ALLOW_ROOTenvironment variable.
Signed-off-by: Joe Ellis joe.ellis@arm.com